chore: bump ASAPController rev pin to pick up SummaryExecutor - #410
Merged
Merged
Conversation
control_plane and asap_types were pinned to 01745cce, which predates
ASAPController#155 ("feat(sketch): SummaryExecutor -- serving-time
execution model for L4Node"). Bump both to fc09c3a (current main tip,
a strict descendant) so `asap_sketch::exec::{SummaryExecutor, execute}`
is available -- needed to implement
data_plane/docs/l4node-plan-executor-design.md (Step C).
asap_types' pin comment already requires it to match control_plane's
exactly (two revs of the same git dep resolve to distinct Rust types
that won't unify), so both move together.
Verified: `cargo check --workspace` clean; `cargo test -p control_plane
-p asap_types` has the same single pre-existing failure
(invalid_sketch_type_override_falls_back_to_default) on this rev and
on unmodified main -- unrelated to this bump, not introduced by it.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
control_plane/asap_typeswere pinned to ASAPController rev01745cce,which predates ASAPController#155 ("feat(sketch): SummaryExecutor --
serving-time execution model for L4Node"). Bumps both to
fc09c3a(current
maintip, a strict descendant) soasap_sketch::exec::{SummaryExecutor, execute}is available.This is prerequisite plumbing for implementing
data_plane/docs/l4node-plan-executor-design.md(Step C, #409) --ASAPQueryEngineneedsSummaryExecutorin scope before it canimplement it.
asap_types/Cargo.toml's existing pin comment requires it to matchcontrol_plane's exactly (two revs of the same git dependency resolveto two distinct Rust types that won't unify), so both pins move
together, same as every prior bump.
Test plan
cargo check --workspace-- clean, no new warnings.cargo test -p control_plane -p asap_types-- 765 passed, 1pre-existing failure (
invalid_sketch_type_override_falls_back_to_default).Verified this failure is not introduced by this bump: it fails
identically on unmodified
main(930cb78) before this change.Leaving it as-is -- out of scope for a rev-pin bump; flagging here
for a separate fix.
🤖 Generated with Claude Code