Skip to content

Step 5: split AggregationType into AccumulatorSpec (SummaryKind + typed params + grouping) #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzylol merged 3 commits into from
Jul 22, 2026
Merged

Step 5: split AggregationType into AccumulatorSpec (SummaryKind + typed params + grouping) #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b21b99
feat(asap_types, data_plane): split AggregationType into AccumulatorSpec
zzylol Jul 21, 2026
4a41f31
fix(asap_types): repoint accumulator_spec.rs import after promql_util…
zzylol Jul 21, 2026
c58239a
fix(asap_types): rename WindowType to WindowKind in accumulator_spec.…
zzylol Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions crates/asap_types/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,12 @@ xxhash-rust = { version = "0.8", features = ["xxh64"] }
# unification (scratchpad/artifacts/enum-unification-plan.md). Pin matches
# control_plane's -- see control_plane/Cargo.toml's comment for the rationale.
asap-ir = { git = "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/ProjectASAP/ASAPController", rev = "01745cceac857be21fd1d80584c045e6f932ebfc" }
# Step 5 of the sketch-identity unification (see
# scratchpad/artifacts/enum-unification-plan.md): `AccumulatorSpec`
# (accumulator_spec.rs) converges data_plane's identity representation
# onto ASAPController's `SummaryKind`/`SummaryParams`, same as
# control_plane already does (Stage 3, merged). Pin MUST match
# control_plane's pin exactly (`control_plane/Cargo.toml`) -- two
# different revs of the same git dependency in one workspace resolve
# to two distinct Rust types that won't unify.
asap-sketch = { git = "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/ProjectASAP/ASAPController", rev = "01745cceac857be21fd1d80584c045e6f932ebfc" }
Loading