test(monitor): fix monitor_grpc integration-test compile (rate field from #368) - #369
Merged
Merged
Conversation
…ion-test compile The dynamic sampling-coupling change (#368) added MonitorReport.rate but didn't update the tests/monitor_grpc.rs report() helper, leaving the integration test uncompilable (E0063: missing field `rate`). The --lib suite was green so it slipped through (integration tests build separately). Set rate: 0.0 (unknown — preserves the existing slack-only behavior the test asserts). The live-gRPC alert test now compiles + passes: fires_alert_once_past_tau (alert fires once at estimate≥(1-ε)τ over real gRPC) + quiet_below_tau. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dynamic sampling-coupling (#368) added
MonitorReport.ratebut didn't updatetests/monitor_grpc.rsreport(), leaving the live-gRPC alert integration test uncompilable (E0063). The--libsuite was green so it slipped through (integration tests compile separately).Fix:
rate: 0.0in the test helper. The test now compiles + passes —fires_alert_once_past_tau(alert fires once over real gRPC when the scripted reports climb past τ) andquiet_below_tau.🤖 Generated with Claude Code