refactor(gorilla-merger): import coldpart from asap-gorilla-go, drop internal copy - #338
Merged
Merged
Conversation
…e internal copy The cold "Part" format moved to the shared asap-gorilla-go/coldpart package so the edge agent can produce parts too. Re-point the merger's cold part store and decode-on-read query path at github.com/ProjectASAP/asap-gorilla-go/coldpart (resolved via the existing replace to the sibling asap-gorilla-go checkout) and delete the now-duplicate internal/coldpart package. No behavior change; the wire format and StoreAPI are byte-for-byte identical. Depends on the ASAPCollector change that adds asap-gorilla-go/coldpart; merge that PR first. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second of a two-PR change. Merge the ASAPCollector PR (ProjectASAP/ASAPCollector#439) FIRST — it adds
asap-gorilla-go/coldpart, which this PR imports.coldpartstore.go) and decode-on-read query path (coldquery.go, plus the store test) atgithub.com/ProjectASAP/asap-gorilla-go/coldpartinstead of the in-repointernal/coldpart.gorilla-merger/internal/coldpart(now duplicated in the shared lib).replace github.com/ProjectASAP/asap-gorilla-go => ../../ASAPCollector/asap-gorilla-gois unchanged; coldpart now resolves from that sibling checkout.The cold Part wire format and the
/ingest/coldpartStoreAPI are byte-for-byte identical — this is a pure relocation so the edge agent (a different module) can also import the format and produce parts.Test plan
cd gorilla-merger && go build ./...green (resolvescoldpartfrom the siblingasap-gorilla-gocheckout).cd gorilla-merger && go test ./...green (incl.internal/mergercold-part-store tests that exercise the relocatedcoldpart).go vet/gofmtclean.asap-gorilla-go/coldpart(i.e. after backend-plan: serving-time cutover -- prefer plan over SketchStore reconstruction (Phase 4) #439 merges).🤖 Generated with Claude Code