refactor(sketch-db): merge simple_map_store into sketch_db module tree - #33
Merged
Merged
Conversation
The sketch DB has two structurally-layered pieces that have been living as sibling modules: - `src/stores/sketch_db/` (logical layer: schemas, timelines, backfill) - `src/stores/simple_map_store/` (physical layer: per-key storage backend) This sibling layout hid the dependency direction: `sketch_db` depends on the `Store` trait implemented by `SimpleMapStore`, not vice versa. The physical store is one concrete implementation of the sketch DB's storage abstraction, not a peer concept. Move `simple_map_store/` INTO `sketch_db/` as a submodule so the module tree reflects the layering: everything sketch-DB-related, including its physical backend, lives under one umbrella. ## What changed - `git mv asap-query-engine/src/stores/simple_map_store → asap-query-engine/src/stores/sketch_db/simple_map_store` - `stores::simple_map_store::*` → `stores::sketch_db::simple_map_store::*` across 20 files (16 backend + 1 bench + 3 internal self-references inside the moved directory). - `stores/mod.rs` drops the `pub mod simple_map_store` declaration but keeps `pub use ... SimpleMapStore` re-export so `crate::stores::SimpleMapStore` still works for all callers. - `sketch_db/mod.rs` adds `pub mod simple_map_store` + `pub use simple_map_store::SimpleMapStore`. ## What didn't change - `crate::stores::SimpleMapStore` public path — callers that import via the top-level `stores::` continue to work unchanged. - `Store` trait still lives at `stores::traits` — it's the neutral interface both the logical layer and the physical impl share. - No code logic changed. No tests added or removed. ## Test plan - [x] Pure rename, zero logic delta. - [x] 647 lib tests pass (same count as PR #32). - [x] `cargo clippy --workspace --all-targets --tests -- -D warnings` clean. - [x] `cargo fmt -- --check` clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure re-organisation. Moves
src/stores/simple_map_store/→src/stores/sketch_db/simple_map_store/so the physical storage backend sits under the sketch-DB umbrella that depends on it.crate::stores::SimpleMapStorepublic path stays stable — only internalstores::simple_map_store::*→stores::sketch_db::simple_map_store::*absolute paths change.sed; each file's change is oneuseline.Why
sketch_dbis the logical layer (schemas, timelines, backfill);simple_map_storeis one physical backend for it. Keeping them as siblings hid the dependency direction. Co-locating under one module tree makes the project identity explicit:sketch_dbis the sketch DB, andsimple_map_storeis its current concrete storage impl.Test plan
--workspace --all-targets --tests -- -D warningsclean.🤖 Generated with Claude Code