gorilla-merger: Thanos Info service + no duplicate external labels - #314
Merged
Merged
Conversation
…xternal labels Two thanos-query interop fixes found during #24 validation: 1) storeapi.go: register the Thanos Info gRPC service alongside Store. thanos- query (v0.41) discovers endpoints via Info; a Store-only server is reachable but undiscoverable ("neither info nor store client found"). Mirrors the sidecar wiring (LabelSet + StoreInfo from the TSDBStore). 2) ingest.go: do NOT stamp external labels (cluster/merger) into stored series at ingest — the TSDBStore adds them at query and the shipper writes them to block meta. Stamping at ingest too produced DUPLICATE cluster/merger labels. Tests updated to assert ingest stores only __name__ + attrs. NOTE: the live StoreAPI query still crashes on a separate, deeper thanos v0.41.0 bug (ReAllocZLabelsStrings corrupt-length OOM under Go 1.25; #39). These fixes are necessary but not sufficient — keep the merger unregistered from thanos- query until #39 is resolved. The ingest -> shipper -> S3 archive path is unaffected and works. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two thanos-query interop fixes from #24 validation: (1) register the Thanos Info gRPC service so thanos-query can discover the merger; (2) stop double-stamping external labels at ingest (the TSDBStore + shipper add them) — fixes duplicate
cluster/mergerlabels. Build + merger unit tests green. NOTE: the live StoreAPI query still crashes on a separate deeper thanos v0.41.0 bug (#39,ReAllocZLabelsStringsunder Go 1.25); keep the merger unregistered from thanos-query until #39 is fixed. Archive (ingest→shipper→S3) path is unaffected.