docs(test): close #272 step 4 — cross-reconfigure tests obsoleted by #280 - #288
Merged
Merged
Conversation
…#272 step 4) Issue #272 step 4 asks to "re-enable the two ignored cross-reconfigure dispatch tests in `tests/schema_timeline_dispatch_tests.rs`". That file no longer exists: it was deleted in PR #280 (B7.5 v2) along with the legacy `handle_query_promql` family it exercised, and its two ignored tests were `panic!()` stubs with no real implementations. The only remaining ignored cross-reconfigure test (`test_get_timeline_returns_segments_after_reconfigure` in `http.rs:2440`) is wedded to the pre-#189 `SchemaRegistry::reconcile()` contract that eagerly populated the timeline source on YAML POST. Post-#189 the sid lifecycle is explicit (see `lifecycle::reconcile_from_streaming_config` module doc): "There is no 'added' set: sids are minted lazily by the ingest path on first write". Re-enabling the test as written requires either an architectural switch to eager sid minting (contradicts the documented sid lifecycle) or rewriting the test to interleave an ingest step (changes the contract being tested) — both out of scope for #272. Updates the `#[ignore]` reason + comment to document this resolution so the next maintainer doesn't re-investigate. No production change; no test count delta (baseline stays 727 lib + 2 ignored). Closes step 4 of #272 as obsoleted by #280. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[ignore]reason + comment on the relatedtest_get_timeline_returns_segments_after_reconfiguretest.Investigation
Issue #272 step 4 asks to re-enable the two ignored cross-reconfigure dispatch tests in
tests/schema_timeline_dispatch_tests.rs.That file no longer exists. It was deleted in PR #280 (B7.5 v2 — legacy
handle_queryfamily retirement) because it exercised the now-deletedhandle_query_promqlpath. Both of its#[ignore]'d tests were never actually implemented — their bodies were literallypanic!("ignored: schema retirement #5 follow-up — re-enable when sid-level cross-reconfigure dispatch lands");stubs. There's nothing to re-enable.The only remaining ignored cross-reconfigure timeline test in
data_planeistest_get_timeline_returns_segments_after_reconfigure(drivers/query/servers/http.rs:2440). I tried re-enabling it; it fails because it expects a YAML POST to/api/v1/streaming-configto immediately populate the timeline with the new agg-config's sids — the pre-#189SchemaRegistry::reconcile()contract. Post-#189 the sid lifecycle is the opposite:lifecycle::reconcile_from_streaming_config's module doc explicitly states "There is no 'added' set: sids are minted lazily by the ingest path on first write". So this test can't pass as written without either (a) changing the architecture or (b) rewriting the test to interleave an ingest — both out of scope for #272.This PR just updates the
#[ignore]reason + the surrounding comment so the next maintainer doesn't have to re-derive this. No production change, no test count delta.Test count delta
Test plan
cargo build -p data_plane: cleancargo test -p data_plane --lib: 727 passed, 0 failed, 2 ignored🤖 Generated with Claude Code