Skip to content

refactor(emit): drop aggregation_id from OTAP YAML + Telegraf TOML wire #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzylol merged 1 commit into from
May 15, 2026
Merged

refactor(emit): drop aggregation_id from OTAP YAML + Telegraf TOML wire #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions control_plane/src/emit/otap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,13 @@ fn build_asap_sketches_config(sp: &EdgeSketchProcessor, window_secs: Option<u64>
} else {
m.insert("mode".into(), Value::String("batch".to_string()));
}
m.insert(
"aggregation_id".into(),
Value::String(sp.aggregation_id.clone()),
);
// PR 5 alignment (mirroring #244 / #246 / #250's wire cleanups):
// `aggregation_id` was the controller-allocated string IDs the
// patched asap-otel processors don't consume — sid identity is
// content-addressed at the backend via `(metric, attrs_fingerprint,
// agg_kind_canonical)`. The field stays on `EdgeSketchProcessor`
// as internal emitter plumbing for cross-stage references during
// the DAG walk; it just doesn't reach the wire here.
m.insert(
"sketch_kind".into(),
Value::String(sketch_kind_tag(&sp.sketch_kind).into()),
Expand Down
7 changes: 6 additions & 1 deletion control_plane/src/emit/telegraf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,12 @@ fn emit_processors_allsketches(
if let Some(w) = window_secs {
out.push_str(&format!(" window_duration = \"{w}s\"\n"));
}
out.push_str(&format!(" aggregation_id = \"{}\"\n", sp.aggregation_id));
// PR 5 alignment (mirroring #244 / #246 / #250's wire cleanups):
// `aggregation_id` was the controller-allocated string the
// patched asap-otel processors don't consume — sid identity is
// content-addressed server-side via `(metric, attrs_fingerprint,
// agg_kind_canonical)`. Field stays on `EdgeSketchProcessor` as
// internal emit plumbing; it just doesn't reach the wire here.
out.push_str(&format!(
" sketch_kind = \"{}\"\n",
sketch_kind_tag(&sp.sketch_kind)
Expand Down