Skip to content

refactor(intent_algebra): fold legacy_lower into the legacy→canonical converter #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzylol merged 1 commit into from
May 14, 2026
Merged

refactor(intent_algebra): fold legacy_lower into the legacy→canonical converter #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions control_plane/src/intent_algebra/column_resolution.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,8 @@ pub fn resolve_column_refs(
/// [`resolve_column_refs`] but skips the `ColumnRef::Named` wrapping —
/// the legacy `Aggregate.keys` field is already a `Vec<String>`.
///
/// Step γ1: used by the legacy→canonical `Aggregate` bridge
/// ([`crate::intent_algebra::aggregate_bridge::bridge_aggregate_to_canonical`])
/// to translate the legacy `keys: Vec<String>` into the canonical
/// `by: Vec<ColumnId>` form.
/// Used by `legacy_to_canonical::convert` to translate a legacy
/// `Aggregate.keys: Vec<String>` into the canonical `by: Vec<ColumnId>`.
pub fn resolve_named_keys(
keys: &[String],
schema: &Schema,
Expand Down
Loading