refactor(sketch_db): move warm_tier reducer to sketch_db/query/ - #180
Merged
Merged
Conversation
Post-M2.3 reorg #4 of 8. Moves `query_engines/asap_query_engine/warm_tier/` → `sketch_db/query/`. Pairs the warm-tier read code with the data it reads, mirroring how `backfill/` is paired with the data it writes. The warm-tier reducer is sketch-DB-specific (decodes sketches, runs them against a SketchStore) — it doesn't belong under the backend-agnostic `query_engines/` umbrella. `asap_query_engine/mod.rs` re-exports `pub use crate::storage_engines::sketch_db::query as warm_tier` so the engine's internal references (and any `warm_tier::*` callers) keep compiling at the legacy path. 5 files relocated. 783/783 lib tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-M2.3 reorg #4 of 8. Moves
query_engines/asap_query_engine/warm_tier/→sketch_db/query/. Pairs read code with the data it reads, mirroring howbackfill/is paired with the data it writes.asap_query_engine/mod.rsre-exportspub use crate::storage_engines::sketch_db::query as warm_tierso legacy paths compile.Test plan
cargo test -p data_plane --lib— 783/783 pass.🤖 Generated with Claude Code