refactor(sketch_db): hoist persistence/ to sketch_db level - #178
Merged
Merged
Conversation
Post-M2.3 reorg #2 of 8. Moves `sketch_db/store/persistence/` → `sketch_db/persistence/` so the disk-persistence layer sits as a top-level sibling of `store/`, `data/`, `schema/`, etc. The previous nesting (`store/persistence/`) implied the persistence layer belonged to the store; in fact it's a parallel concern that any sid-keyed store wires into via the `EpochSource` trait. `store/mod.rs` re-exports `pub use sketch_db::persistence` so legacy paths (`store::persistence::*`) keep compiling. Canonical path is now `sketch_db::persistence::*`. 783/783 lib tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-M2.3 reorg #2 of 8. Moves
sketch_db/store/persistence/→sketch_db/persistence/so the disk layer sits as a top-level sibling ofstore/,data/,schema/, etc.Previous nesting implied the persistence layer belonged to the store; in fact it's a parallel concern that any sid-keyed store wires into via the
EpochSourcetrait.store/mod.rsre-exportspub use sketch_db::persistenceso legacy paths (store::persistence::*) keep compiling. Canonical path is nowsketch_db::persistence::*.Test plan
cargo test -p data_plane --lib— 783/783 pass.🤖 Generated with Claude Code