Skip to content

chore(precompute_engine): delete unused RawPassthroughSink #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzylol merged 1 commit into from
May 13, 2026
Merged

chore(precompute_engine): delete unused RawPassthroughSink #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions data_plane/src/precompute_engine/output_sink.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,32 +158,6 @@ impl OutputSink for SketchIndexSink {
}
}

/// Output sink for raw passthrough mode — forwards raw samples to the store
/// without sketch computation. In this mode the samples are stored as
/// SumAccumulators (one per sample).
pub struct RawPassthroughSink {
store: Arc<dyn Store>,
}

impl RawPassthroughSink {
pub fn new(store: Arc<dyn Store>) -> Self {
Self { store }
}
}

impl OutputSink for RawPassthroughSink {
fn emit_batch(
&self,
outputs: Vec<(PrecomputedOutput, Box<dyn AggregateCore>)>,
) -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
if outputs.is_empty() {
return Ok(());
}
let _span = debug_span!("store_insert_raw", batch_size = outputs.len()).entered();
self.store.insert_precomputed_output_batch(outputs)
}
}

/// A capturing sink for testing that stores all emitted outputs.
pub struct CapturingOutputSink {
pub captured: Mutex<Vec<(PrecomputedOutput, Box<dyn AggregateCore>)>>,
Expand Down