feat(controller): drop aggregationId from asapquery_backend YAML emission - #152
Merged
Merged
Conversation
…sion Phase 5 M2.2 — completes the controller→backend aggregation_id handoff. `controller::emit::asapquery_backend::generate_streaming_config_yaml` no longer writes the `aggregationId` field; the `deterministic_agg_id` helper (and its dedicated test) is removed. The backend's `AggregationConfig::from_yaml_data` now derives the id deterministically via `compute_agg_config_id` (introduced in M2.1 / PR #151) over the same fields the emitter writes, so the explicit field was redundant. In-tree YAML fixtures + the in-process feedback-loop test still mint explicit ids; that path is exercised unchanged because explicit `aggregationId` is honored for backwards compatibility. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zzylol
added a commit
that referenced
this pull request
May 13, 2026
Schema retirement #2 of 5. The `/api/v1/db/timeline` handler now reads from `state.sketch_index` (always attached) via `sketch_db::query::timeline::timeline_for_metric` (PR #183) instead of `state.schemas.timeline_for_metric`. User-visible behavior: - Endpoint always works (no more 503 when schema-registry isn't wired — the sid catalog is always present). - `agg_id` field carries a stable content-derived signature id (xxh64 of `metric + agg_kind + group_by_keys`) instead of the controller-emitted `agg_id` (which is gone after M2.2 / PR #152). - Segments now reflect the sid catalog directly; reconfigure semantics propagate once the next sub-PR (lifecycle reconcile) lands. Test impact: - `test_get_timeline_without_registry_returns_503` rewritten to `..._with_no_sids_returns_empty_200` matching the new semantics. - `test_get_timeline_returns_segments_after_reconfigure` ignored (uses POST /streaming-config → SchemaRegistry::reconcile, which doesn't yet propagate to the sid catalog; re-enabled in the next sub-PR with the lifecycle reconcile). 789/792 lib tests pass (3 ignored — 2 pre-existing + this one). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
controller::emit::asapquery_backend::generate_streaming_config_yamlno longer writes theaggregationIdfield.deterministic_agg_idhelper + its dedicated test are removed (~25 LOC).data_plane::asap_query_engine::engineto reflect the new contract.Backend-side derivation of the id (via
compute_agg_config_idfrom M2.1 / PR #151) over the same fields the emitter writes makes the explicitaggregationIdfield redundant. Existing YAML fixtures + tests that mint explicit ids still work —from_yaml_datahonors them for backwards compatibility.Test plan
emitted_yaml_omits_aggregation_idasserts the field is absent from output.cargo test -p controller --lib emit::asapquery_backend— 5/5 pass.cargo test -p controller --lib— 710/710 pass.cargo test -p data_plane --lib capability_miss_feedback_loop_closes— both feedback-loop tests pass; explicit-id round-trip still verified.cargo check --workspaceclean.What's next
M2.3: migrate
SchemaRegistry/SketchStorefrom agg_id-keyed to sid-keyed lookup (~362 references across 38 files; deeper refactor — needs decomposition).🤖 Generated with Claude Code