cleanup: re-point asap-gorilla path-dep at asap-gorilla-rust directly - #118
Merged
Merged
Conversation
Drop the symlink indirection. Previously
`asap-query-engine/Cargo.toml` had:
asap-gorilla = { path = "../../ASAPCollector/asap-gorilla" }
where `asap-gorilla` was a symlink to `asap-gorilla-rust/`. The symlink
existed for backwards-compat with pre-unify-Gorilla-implementations
(#357) consumers; with the unification done, all readers should refer
to the canonical Rust crate dir directly.
This is the **first** of two coordinated PRs:
1. (this) backend Cargo.toml repointed to `asap-gorilla-rust`
2. (next) collector deletes the now-unused `asap-gorilla` symlink
Merge order: this PR first, otherwise the collector symlink delete
breaks the backend's path resolution.
Verification:
- `cargo check --workspace` → clean.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop the symlink indirection. The backend's path-dep was:
```toml
asap-gorilla = { path = "../../ASAPCollector/asap-gorilla" }
```
where `asap-gorilla` was a symlink to `asap-gorilla-rust/`. The symlink was kept for backwards-compat with pre-unify-Gorilla-implementations (#357) consumers; with unification done, point at the canonical Rust crate dir directly.
This is the FIRST of two coordinated PRs. Merge in this order:
If you flip the order, the collector symlink delete breaks the backend's path resolution.
Test plan
🤖 Generated with Claude Code