Skip to content

fix: warm tier ingests + answers HLL count / KLL quantile (and best-effort CountSketch/CountMin) #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzylol merged 1 commit into from
May 9, 2026
Merged

fix: warm tier ingests + answers HLL count / KLL quantile (and best-effort CountSketch/CountMin) #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions asap-common/dependencies/rs/asap_types/src/capability_matching.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,25 @@ pub fn compatible_agg_types(stat: Statistic) -> &'static [AggregationType] {
AggregationType::HydraKLL,
AggregationType::DDSketch,
],
Statistic::Rate | Statistic::Increase => {
&[AggregationType::Increase, AggregationType::MultipleIncrease]
}
// Rate / Increase: the canonical exact accumulators are the
// counter-shaped Increase / MultipleIncrease, but `rate(...)`
// and `increase(...)` over a CountMinSketch-backed agg are
// also valid — CMS records every insert and answers
// `Statistic::Rate` natively (events / range_ms when the
// engine passes `range_ms` in query_kwargs; raw event count
// as a units-of-events/window fallback otherwise — see
// `precompute_operators/count_min_sketch_accumulator.rs`).
// Without CMS / CMSWithHeap listed here, `rate(metric[5m])`
// against a CMS-only config — the canonical MVP demo
// CountMin path — capability-misses and the warm engine
// returns `status=error`. Closes the PR #111 honest-gap
// call-out for `Statistic::Rate` not implemented.
Statistic::Rate | Statistic::Increase => &[
AggregationType::Increase,
AggregationType::MultipleIncrease,
AggregationType::CountMinSketch,
AggregationType::CountMinSketchWithHeap,
],
// Cardinality: SetAggregator / DeltaSetAggregator are the
// exact key trackers; HLL is the canonical approximator
// whose accumulator answers `Statistic::Cardinality` (and
Expand Down
Loading