Skip to content

Remove local Docker dependency overrides after sibling repositories are public #735

Description

@milindsrivastava1997

Context

The PromQL compliance Compose build currently supplies ASAPCollector and asap_sketchlib as local Docker build contexts and installs Docker-only Cargo patches. This lets image builds resolve the current private Git dependencies without passing GitHub credentials into Docker.

Follow-up

Once ASAPCollector and asap_sketchlib are public, remove the local build contexts and Docker-only Cargo path patches from data_plane/Dockerfile and control_plane/Dockerfile. Let Cargo resolve the pinned Git dependencies from the repository and lockfile normally.

Acceptance

  • Docker builds do not require sibling checkouts.
  • Docker builds use the public pinned Git dependencies.
  • promql-compliance/docker-compose.yml has no local dependency build contexts.
  • The PromQL compliance Compose run can build from a normal backend checkout.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions