feat(sql): lower typed Struct field access - #399
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClickHouse
tupleElementcould not reach the existing typed Struct-field expression. This adds a planning adapter that delegates field selection to the shared resolver and exportsasap_struct_field; it does not add another Tuple type or scalar return-type policy.Before, selecting a declared Struct field was unsupported. After,
tupleElement(sample, 1)andtupleElement(sample, 'value')retain the selected field's type and nullability. Dynamic, missing, and unsupported ordinal selectors fail closed. A private adapter dispatch distinguishes Map, element lookup, and Struct-field lookup while all semantic rules remain shared.Verification: all frontend SQL tests passed, including 93 lowering tests, ordinal/name selection, nullable fields, invalid selectors, and the existing original o11y Map queries. Physical execution remains the backend's responsibility and requires its matching Struct consumer. Numeric
x.1syntax, lambdas, and full counter-query acceleration are not implemented by this change. No performance claim.