feat(types): derive generic collection element types - #397
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array-backed expressions need the declared element type before they can participate in typed DAG composition. Reusing the Map-only access name for arrays would blur two different lookup contracts.
This adds canonical
asap_element_access(input, index)typing through the existing QueryExpr scalar resolver. Map inputs delegate to the established Map signature; List inputs preserve element type and nullability, including nested Struct metadata. Integer indices support one-based positive and negative indexing; nullable indices make results nullable. Literal zero is conservatively rejected because native behavior depends on array constantness.Before, a generic collection lookup had no authoritative signature. After, nested element/field expressions derive their types from existing List/Struct definitions. Legacy
asap_map_accessremains compatible. No frontend emission or new wire DTO is introduced; backend support and its Planner pin must land together before new queries use the generic name.Verification: all 196 shared type tests pass, including List(Struct)→field composition, negative/dynamic nullable indices, invalid-index rejection, Map compatibility and serde roundtrip. Runtime/performance evidence is not applicable to this typing contract. Nullable containers, collection construction, lambda scope and native output formatting remain separate work.