feat(workload): define canonical workload wire format - #341
Merged
Merged
Conversation
zzylol
force-pushed
the
feat/cost-window-framework-selection
branch
from
September 4, 2026 01:04
739753e to
000fe98
Compare
zzylol
force-pushed
the
feat/window-workload-snapshot-wire
branch
from
September 4, 2026 01:28
cb50219 to
522c0fe
Compare
zzylol
force-pushed
the
feat/cost-window-framework-selection
branch
from
September 4, 2026 02:26
000fe98 to
cb1e2e4
Compare
zzylol
force-pushed
the
feat/window-workload-snapshot-wire
branch
from
September 4, 2026 02:29
522c0fe to
9ed473b
Compare
zzylol
force-pushed
the
feat/cost-window-framework-selection
branch
from
September 4, 2026 03:13
cb1e2e4 to
334ac1b
Compare
zzylol
force-pushed
the
feat/window-workload-snapshot-wire
branch
from
September 4, 2026 03:17
9ed473b to
c92f4ac
Compare
zzylol
force-pushed
the
feat/cost-window-framework-selection
branch
from
September 4, 2026 03:33
45ea342 to
1d19224
Compare
zzylol
force-pushed
the
feat/window-workload-snapshot-wire
branch
from
September 4, 2026 03:37
c92f4ac to
556c6c8
Compare
zzylol
force-pushed
the
feat/cost-window-framework-selection
branch
from
September 4, 2026 04:02
1d19224 to
48c01f7
Compare
zzylol
force-pushed
the
feat/window-workload-snapshot-wire
branch
from
September 4, 2026 04:02
556c6c8 to
9949fcc
Compare
zzylol
changed the base branch from
feat/cost-window-framework-selection
to
main
September 4, 2026 11:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ASAPPlanner and downstream components need one wire representation for the existing canonical
QueryWorkloadandDataWorkloadtypes. Copying them into a second DTO would let recurrence, time selection, accuracy, evidence freshness, and data-arrival semantics drift.What
promql,sql,datafusion,elastic_dsl,datafusion_sql,clickhouse_sql, andelastic_sql.AccuracyTarget::EpsilonDelta.Boundary
Deserialization establishes only the wire shape. Callers must still invoke
QueryWorkload::validatebefore planning; semantic validation rejects invalid rates, recurrence, confidence, latency, and data-arrival combinations. Evidence freshness is intentionally time-dependent and is checked separately throughEvidence::is_fresh_at(planning_time), not during deserialization or static workload validation.This PR intentionally serializes the existing source-of-truth workload enums instead of defining new streaming or deployment enums.
Verification
cargo test -p asap-types workload::testscargo clippy -p asap-types --all-targets -- -D warningscargo fmt --all -- --checkThis PR is independently based on #338; it is not a prerequisite of #339.