Conversation
zzylol
force-pushed
the
feat/cost-promql-stack-linear
branch
from
September 2, 2026 19:28
c7d79aa to
c402f0b
Compare
zzylol
force-pushed
the
fix/cost-estimator-invariants
branch
from
September 2, 2026 19:28
44d8dab to
e32d209
Compare
zzylol
force-pushed
the
feat/cost-promql-stack-linear
branch
from
September 3, 2026 02:54
c402f0b to
f6a62ad
Compare
zzylol
force-pushed
the
fix/cost-estimator-invariants
branch
from
September 3, 2026 02:54
e32d209 to
9d35b6d
Compare
zzylol
marked this pull request as ready for review
September 3, 2026 03:17
zzylol
force-pushed
the
feat/cost-promql-stack-linear
branch
from
September 3, 2026 16:11
f6a62ad to
9f48885
Compare
zzylol
force-pushed
the
fix/cost-estimator-invariants
branch
from
September 3, 2026 16:13
9d35b6d to
9d7dfc2
Compare
zzylol
force-pushed
the
feat/cost-promql-stack-linear
branch
from
September 3, 2026 16:29
9f48885 to
72bb94d
Compare
zzylol
force-pushed
the
fix/cost-estimator-invariants
branch
from
September 3, 2026 16:29
9d7dfc2 to
3fc1aff
Compare
zzylol
changed the title
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A PromQL presence/absence operator can emit at most one result per evaluation step. Accepting larger output evidence would under-specify the physical semantics and could distort parent costs.
What
PromqlPresenceevidence whose output rows exceed the number of evaluation steps.How
The physical DAG validator compares output cardinality with the already validated recurrence count before estimation.
Before
Contradictory absence/presence output cardinality could pass validation.
After
Such a candidate is unavailable with a semantic-invariant error.
Validation
cargo test -p asap-aware-mappingcargo clippy --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkDepends on #328. #330 adds complete-plan comparison and ranking.