Skip to content

fix(devtools): clean up Pre/Post-ASAP DAG viewer - #284

Merged
zzylol merged 1 commit into
feat/dag-post-asap-vizfrom
fix/dag-viewer-cleanup
Aug 26, 2026
Merged

zzylol merged 1 commit into
feat/dag-post-asap-vizfrom
fix/dag-viewer-cleanup

Conversation

@zzylol

@zzylol zzylol commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Stacked on #283. This follow-up keeps #283 unchanged while addressing the DAG-viewer review findings:

  • use exporter-assigned workload_node_id for shared-node highlighting
  • aggregate explicit post-ASAP decisions from every owner of a merged workload node
  • remove obsolete Single/Compare/Union rendering and detail paths
  • remove the unused SVG icon system, stale edge-schema selector, and old Before/After naming
  • stop Python from preprocessing replacement mini-graphs that the current viewer does not render
  • update the viewer contract/docs to describe explicit workload identity

The viewer still resolves target_pre_id and replacement output kind through the explicit decision_id mapping in exported JSON; it does not infer node signatures, strategies, or sharing in the browser.

Validation

  • python3 -m unittest discover -s tools/dag-viewer -p 'test_render.py' (18 passed)
  • cargo test -p asap-devtools --bin dag_export (6 passed)
  • cargo clippy -p asap-devtools --bin dag_export -- -D warnings
  • standalone HTML generated from post_asap_fixture.json
  • viewer.js/node-style.js syntax parsed (modern optional chaining normalized for the installed parser)

Stack

Base: #283 (feat/dag-post-asap-viz)

@zzylol
zzylol merged commit 999abc0 into feat/dag-post-asap-viz Aug 26, 2026
@zzylol
zzylol deleted the fix/dag-viewer-cleanup branch August 26, 2026 14:01
zzylol added a commit that referenced this pull request Aug 26, 2026
zzylol added a commit that referenced this pull request Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant