Skip to content

feat(asap-aware-mapping): select CSE using effective cross-group costs #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzylol merged 1 commit into from
Aug 25, 2026
Merged

feat(asap-aware-mapping): select CSE using effective cross-group costs #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/asap-aware-mapping/src/cost_model.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,7 @@ mod tests {
replacement: Replacement::Summary(Rc::new(summary_node(SummaryFamilyType::Plain(
asap_types::pre_asap::DataType::Float64,
)))),
provenance: crate::replacement::ReplacementProvenance::SummaryImplementation,
rationale: "whatever".into(),
};
assert!(RankOnly.estimate_cost(&candidate, &target).is_nan());
Expand All @@ -893,6 +894,7 @@ mod tests {
replacement: Replacement::Summary(Rc::new(summary_node(
SummaryFamilyType::ExactAggregate(ExactKind::Sum, ExactParams::Sum),
))),
provenance: crate::replacement::ReplacementProvenance::SummaryImplementation,
rationale: "exact accumulator".into(),
};
let pricey = ReplacementSubDAG {
Expand All @@ -902,6 +904,7 @@ mod tests {
family: "gaussian_mixture".into(),
},
)))),
provenance: crate::replacement::ReplacementProvenance::SummaryImplementation,
rationale: "fitted statistical model".into(),
};

Expand Down Expand Up @@ -934,10 +937,12 @@ mod tests {

let share = ReplacementSubDAG {
replacement: Replacement::Rewrite(Rc::clone(&target_root)),
provenance: crate::replacement::ReplacementProvenance::CseShare,
rationale: "build once and share".into(),
};
let recompute = ReplacementSubDAG {
replacement: Replacement::Rewrite(Rc::new((*target_root).clone())),
provenance: crate::replacement::ReplacementProvenance::CseRecompute,
rationale: "build independently".into(),
};

Expand Down
1 change: 1 addition & 0 deletions crates/asap-aware-mapping/src/grouping.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ impl<'a> HydraGroupingStrategy<'a> {
let patched = with_grouping(node, grouping);
Some(ReplacementSubDAG {
replacement: Replacement::Summary(patched),
provenance: crate::replacement::ReplacementProvenance::SummaryImplementation,
rationale: format!(
"{} realizes as a shared {hydra_kind:?} structure over {sketch_kind:?} \
serving every subpopulation of this grouped aggregate, instead of one \
Expand Down
7 changes: 4 additions & 3 deletions crates/asap-aware-mapping/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,9 @@ pub use explanation::{
pub use grouping::{has_subpopulations, HydraGroupingStrategy};
pub use replacement::{
default_strategies, default_strategies_with, search_workload, search_workload_with,
summary_candidates, ImplementError, Implementation, Matcher, MemoGroup, PlanSpace, RankedGroup,
Replacement, ReplacementStrategy, ReplacementSubDAG, SharedSubtreeStrategy,
SketchAlgorithmStrategy, TargetSubDAG, MAX_SEARCH_ITERATIONS,
summary_candidates, GlobalSelection, ImplementError, Implementation, Matcher, MemoGroup,
PlanSpace, RankedGroup, Replacement, ReplacementProvenance, ReplacementStrategy,
ReplacementSubDAG, SelectedGroup, SharedSubtreeStrategy, SketchAlgorithmStrategy, TargetSubDAG,
MAX_SEARCH_ITERATIONS,
};
pub use rewrite::AvgToSumOverCountStrategy;
Loading
Loading