fix: remove QueryExpr::Window — no producer exists - #193
Merged
Merged
Conversation
L2→L3 conversion collapses every L2 Window (bare range vector) into canonical TimeRange unconditionally (crates/l2/src/lower.rs); nothing ever constructs canonical QueryExpr::Window. Confirmed empirically by walking every lowered query across all 7 corpora (~2600 queries). Drops the variant, its output_schema arm, WindowKind (its only field type, now itself unused), and every match arm across dag_export, canonicalize's children walker, variant_coverage, and test files. L2's own relational::QueryExpr::Window (a distinct, still-live type) is untouched. Fixes #182 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueryExpr::Window(canonical L3 IR) has no producer: L2→L3 conversion collapses every L2Window(bare range vector) intoTimeRangeunconditionally (crates/l2/src/lower.rs). Confirmed empirically by walking every lowered query across all 7 corpora (~2600 queries).output_schemaarm,WindowKind(its only field type, now itself unused), and every match arm acrossdag_export,canonicalize's children walker,variant_coverage, and test files.relational::QueryExpr::Window(a distinct, still-live type) is untouched.output_schema_in(scope)tooutput_schema()across the same match statement; this PR's diff reflects that.Fixes #182
Test plan
cargo build --workspace --testscargo test --workspace(full suite green)cargo clippy --workspace --all-targets🤖 Generated with Claude Code