fix: restore dag_export README swap dropped by a stale squash-merge of #176 - #177
Merged
Merged
Conversation
…by a stale squash-merge PR #176's squash-merge (via gh pr merge) used a stale cached PR head on GitHub's side and landed the pre-#134-merge content: the README still had the topk_ir/{:#?} section, and none of #134's actual files (crates/ir/src/dag_export.rs, crates/lower/examples/dag_export.rs, tools/dag-viewer/) made it into main. This restores exactly the tree that was actually reviewed and verified (build/test/clippy clean, dag_export CLI run end-to-end) before the merge: the query-DAG JSON exporter + offline HTML viewer (#134, with the Aggregate::by -> reduction compile fix), and the README's 'Visualize the IR' section pointing at it instead of topk_ir. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #176's squash-merge landed a stale version of the branch — GitHub's merge endpoint used a cached PR head rather than the branch's actual final commit, so `main` ended up with the pre-#134-merge content: the README still has the `topk_ir`/`{:#?}` visualization section, and none of #134's files (`crates/ir/src/dag_export.rs`, `crates/lower/examples/dag_export.rs`, `tools/dag-viewer/`) made it in.
This restores exactly the tree that was actually reviewed before merging #176: the query-DAG JSON exporter + offline HTML viewer (#134, including the `Aggregate::by` → `reduction` compile fix), and the README's "Visualize the IR" section pointing at `dag_export`/`tools/dag-viewer` instead of `topk_ir`.
Diffed directly against the verified branch tip to confirm zero drift (`git diff origin/main -- .` empty after applying).
Test plan
🤖 Generated with Claude Code