DEBS benchmark: Core Code for Accuracy Checking and Replay - #97
Merged
Merged
Conversation
GnaneshGnani
force-pushed
the
debs_benchmark
branch
from
April 1, 2026 00:44
7a6753c to
f580d7c
Compare
GnaneshGnani
force-pushed
the
debs_controller
branch
from
April 1, 2026 00:44
af55d1d to
58c791f
Compare
GnaneshGnani
force-pushed
the
debs_benchmark
branch
from
April 1, 2026 01:05
cf7900b to
fb394a3
Compare
GnaneshGnani
changed the title
zzylol
reviewed
Apr 1, 2026
Contributor
|
What do you mean by |
zzylol
requested changes
Apr 1, 2026
Contributor
Author
|
Verification means comparing the ground truths for the statistical queries with the sketch output |
GnaneshGnani
force-pushed
the
debs_benchmark
branch
from
April 3, 2026 00:56
fb394a3 to
02c534b
Compare
GnaneshGnani
force-pushed
the
debs_benchmark
branch
from
April 3, 2026 01:16
02c534b to
ad30e0a
Compare
Contributor
Author
Contributor
Let's rename it as "accuracy check" |
zzylol
changed the title
zzylol
approved these changes
Apr 4, 2026
zzylol
requested changes
Apr 4, 2026
zzylol
left a comment
zzylol
left a comment
Contributor
There was a problem hiding this comment.
Let me resolve the updates in controller and I think the datasets/eval part is okay to merge.
Rebased on latest main. Dropped stale controller changes (already on main via PRs #96, #116, #117, #119). Only benchmark tooling remains: - replay.py: replay DEBS dataset through OTel collector - run.py: orchestrate benchmark runs - scrape.py: collect Prometheus metrics during run - analyze.py: parse benchmark results - compare.py: compare sketch results to ground truth - summarize.py: generate summary tables - ground_truth/: ground truth computation for accuracy checking Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
zzylol
approved these changes
Apr 4, 2026
SieDeta
pushed a commit
that referenced
this pull request
Apr 17, 2026
Rebased on latest main. Dropped stale controller changes (already on main via PRs #96, #116, #117, #119). Only benchmark tooling remains: - replay.py: replay DEBS dataset through OTel collector - run.py: orchestrate benchmark runs - scrape.py: collect Prometheus metrics during run - analyze.py: parse benchmark results - compare.py: compare sketch results to ground truth - summarize.py: generate summary tables - ground_truth/: ground truth computation for accuracy checking Co-authored-by: zz_y <zeyingz@umd.edu> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
10 tasks
zzylol
added a commit
that referenced
this pull request
May 8, 2026
…rt + archive-tier accuracy ground truth (#332) This is the Option-B-as-sole-path validation re-run. With PR #329 (controller bootstrap GET → typed-stage-split) merged, the driver's post-stack-up `POST /api/v1/plan` workaround (PR #328) is redundant for the bootstrap path. Default it OFF so we can verify the bootstrap GET actually carries the load; operators can keep the safety belt by setting `ENABLE_OPTION_A_DRIVER_POST=1`. Three coupled fixes also land here so the demo's verdict matrix returns to all-green: 1. Backend container was crashing immediately on startup because `deploy/docker-compose/base.yml` passed `--ingest-port=9090` to a binary (`precompute_engine`, the deployed Dockerfile.backend target) that has no such flag — clap exited with `unexpected argument` and every subsequent Connection refused / failed POST from the controller cascaded from there. Drop the invalid flag and the redundant `19090:9090` host publish (Prometheus remote-write was deleted in ASAPQuery-backend PR #100; OTLP-only ingest goes over 4317 intra-docker). 2. `accuracy_reduce.py` is ported off the deleted `/var/asap/cold/raw/` JSONL tee onto the archive-engine-via-header path: `--cell-dir` re-issues each replay PromQL with `X-ASAP-Engine: thanos_archive` (Step 2.3 / PR #97) for ground truth. The driver's accuracy phase is rewritten to drop the `docker cp cold-truth/` step that was failing silently and skipping the entire reduce. The legacy JSONL path is kept behind `--use-jsonl` / `--use-jsonl-truth`. 3. STATUS detection in `capture_emitted_configs()` recognises the bootstrap-time typed marker (`[USE_TYPED_STAGE_SPLIT] emitted bootstrap config from typed path`) so a successful Option-B bootstrap renders as `live-bootstrap` even when the Option-A POST is gated off and `pushing typed` never fires. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmarking harness for DEBS 2022 queries under
datasets_eval/debs/benchmark/.common.py:DEBS_ROOT,data_path(),day_to_filename(), query group constantsreplay.py: chunked CSV read, OTLP gauge replayscrape.py: pull metrics from collector/Prometheuscompare.py: shared comparison infrastructure (get_best_snapshot_for_query,extract_ddsketch_median,_COMPARE_DISPATCH); per-query compare functions added by eachdebs_q*PRanalyze.py: latency/throughput report generationrun.py: orchestrates throughput / latency / compare modesrequirements.txt,.gitignoreBase:
debs_gt(merge after PR #110).