perf(precompute): index oldest-series eviction - #601
Merged
Merged
Conversation
zzylol
force-pushed
the
fix/596-generation-safe-activation
branch
from
September 4, 2026 12:08
c0cac2b to
afae724
Compare
zzylol
force-pushed
the
perf/592-indexed-series-eviction
branch
from
September 4, 2026 12:08
c82593c to
2c7ed60
Compare
zzylol
force-pushed
the
fix/596-generation-safe-activation
branch
from
September 4, 2026 12:09
afae724 to
6ec19d3
Compare
zzylol
force-pushed
the
perf/592-indexed-series-eviction
branch
from
September 4, 2026 12:09
2c7ed60 to
a00f09d
Compare
zzylol
changed the base branch from
fix/596-generation-safe-activation
to
main
September 4, 2026 12:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #592.
Replaces the O(MaxSeries) map scan with a deterministic min-heap keyed by
(LastSeenMs, seriesKey). Admissions and recency updates are O(log N), while eviction is O(log N).Also centralizes eviction cleanup: cached snapshots are removed and sketches are returned to the configured pool (or reset when no sink exists). Scalar, keyed, and envelope admissions maintain the same index.
Adds a cap-churn benchmark at 1k/10k/100k series. On the review host, 50-iteration samples were ~1.6µs/~2.8µs/~3.8µs per eviction with constant 304 B/op, instead of a linear full-map scan.
Stacked on #600.