Conversation
…mode, aggregate_by) - Rename window_size (countsketch) and window_interval (countminsketch) to window_duration to match hll/kll/ddsketch naming - Change default mode for countsketch and countminsketch from window to batch, matching hll/kll/ddsketch defaults - Add aggregate_by and label_matchers to countsketch and countminsketch configs, with full cross-series aggregation support implemented in countminsketch - Note series_per_sketch in SDK PipelineConfig as benchmark-only Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…y and label_matchers smoke tests - Fix TestConfigValidate in countsketchprocessor: window_duration validation only runs in window mode, so set mode=window before testing the minimum - Add TestAggregateBy: verifies two series with same aggregate_by label collapse to one sketch output data point with only the grouped labels retained - Add TestLabelMatchers: verifies data points not matching label_matchers are excluded from the sketch (sample_count reflects only matching points) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
zzylol
deleted the
57-unifying-the-interface-between-collector-and-sdk-and-application
branch
March 19, 2026 18:39
SieDeta
pushed a commit
that referenced
this pull request
Apr 17, 2026
…ween-collector-and-sdk-and-application feat: unify sketch processor config interface
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window_durationfield: Renamedwindow_size(countsketch) andwindow_interval(countminsketch) towindow_duration, matching the field name already used by hll/kll/ddsketchbatch: Changed default mode for countsketch and countminsketch fromwindowtobatch, matching hll/kll/ddsketch defaultsaggregate_by+label_matchers: Added both fields to countsketch and countminsketch configs; countminsketch gets full cross-series aggregation (same model as hll/kll/ddsketch —seriesKeyuses onlyaggregate_bylabels, output data points carry only those labels); countsketch getslabel_matchersfilteringseries_per_sketchinPipelineConfigas benchmark-onlyTest plan
go test ./processor/countsketchprocessor/...)go test ./processor/countminsketchprocessor/...)window_durationfieldaggregate_byon countminsketch: two series sharing the sameaggregate_bylabel values should be merged into one sketch🤖 Generated with Claude Code