feat(sdk): RowSampledSketch OTLP wire transport for both grpc/http exporters - #540
Merged
Merged
Conversation
This was referenced Jul 17, 2026
zzylol
force-pushed
the
split/pr-sdk-row-sampling-types
branch
from
July 17, 2026 17:52
3d7bf08 to
4475568
Compare
…porters Dispatches a RowSampledSketch metric point as a standard Gauge/ NumberDataPoint with 3 reserved attributes (raw occurrence count, admission bitmask, and sample_p) — no new proto message needed, both otlpmetricgrpc and otlpmetrichttp transform paths generated from the same shared metricdata.go.tmpl source. Depends on PR-B's RowSampledSketch Aggregation (split/pr-sdk-row-sampling-types) — based on that branch. go.mod/go.sum: derived via `go mod tidy` against current main's dependency baseline rather than copied wholesale from feat/gos-unified-monitoring, which carries unrelated dependency-version drift from that branch's independent history. Only the new asap-precompute-go transitive dependency (pulled in via PR-B's sdk/metric change) and its local-module replace directives were added. Extracted from #518 (stale base); wire-format logic sourced from feat/gos-unified-monitoring, confirmed clean apply against current main. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
zzylol
force-pushed
the
split/pr-otlp-row-sampled-transport
branch
from
July 17, 2026 17:53
460b60b to
3eb0e29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RowSampledSketchmetric point as a standard Gauge/NumberDataPoint with 3 reserved attributes (raw occurrence count, admission bitmask, sample_p) — no new proto message needed.otlpmetricgrpcandotlpmetrichttptransform paths generated from the same sharedmetricdata.go.tmplsource, kept in sync.Context
Third of the 5-PR split extracting #518's remaining unmerged scope (see #538, #539). Depends on #539's
RowSampledSketchAggregation, so this PR is based onsplit/pr-sdk-row-sampling-types, notmain— stack it behind #538 → #539.go.mod/go.sumwere derived viago mod tidyagainst currentmain's dependency baseline rather than copied wholesale fromfeat/gos-unified-monitoring— that branch carries unrelated dependency-version drift from its own independent history unrelated to this feature. Only the newasap-precompute-gotransitive dependency (pulled in via #539'ssdk/metricchange) and its local-module replace directives were added.Test plan
go mod tidy && go build ./... && go vet ./... && go test ./...in bothotlpmetricgrpcandotlpmetrichttp(viarestore_all.sh) — all pass🤖 Generated with Claude Code