feat(gos): retire CMS local point-query under GOS mode (cms_point) - #531
Merged
Merged
Conversation
CMS's threshold.functional=cms_point readout (CMSWrapper.EstimateCount, a min-across-rows estimate) is poisoned by any single row a GOS-active cell reset in place at insert time (design-gos-unified-edge-telemetry.md §11). Reject the combination at boot (config_validate.go) and gate it at runtime (precompute.rewireMonitorHooks) for live control-plane config pushes that bypass YAML validation. Scoped to CMS only: plain CountSketch serves the same functional via a median across signed rows, which tolerates a reset row fine, so it is left unaffected by GOS mode. A CMS series not running in GOS mode is likewise unaffected — cells never reset mid-window in fixed mode. Part of the GOS per-family stack (base: reattach #518 / split/pr-518-reattach-sampled-gos). 🤖 Generated with Claude Code Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
4 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the GOS per-family stack (base: reattach #518
split/pr-518-reattach-sampled-gos/ #530).CMS's
threshold.functional=cms_pointreadout (CMSWrapper.EstimateCount, a min-across-rows estimate) is poisoned by any single row a GOS-active cell reset in place at insert time (design-gos-unified-edge-telemetry.md§11). Reject the combination at boot (config_validate.go) and gate it at runtime (precompute.rewireMonitorHooks) for live control-plane config pushes that bypass YAML validation.Scoped to CMS only: plain CountSketch serves the same functional (
FunctionalCMSPoint) via a median across signed rows, which tolerates a reset row fine, so it is left unaffected by GOS mode. A CMS series not running in GOS mode is likewise unaffected — cells never reset mid-window in fixed mode.Test plan
TestConfigValidate_CMSPointRetiredUnderGOS: boot-time rejection of CMS+GOS+cms_point; acceptance of CMS+GOS w/o cms_point monitor, CMS+cms_point w/o GOS, and CountSketch+GOS+cms_point.TestMonitor_CMSPoint_RetiredUnderGOS/TestMonitor_CMSPoint_FixedModeStillWorks/TestMonitor_CMSPoint_CountSketchUnaffectedByGOS: runtime gate inrewireMonitorHooks, covering the control-plane-push path that bypasses YAML validation.asap-precompute-goand the processor.🤖 Generated with Claude Code