fix(asapedgeprocessor): remove stray gos_* field refs that broke main build - #523
Merged
Merged
Conversation
… build processor.go referenced fam.GosDeltaEpsilon/GosSites/GosAnisotropic and sketchOpts.gosDeltaEpsilon/gosSites/gosAnisotropic, none of which exist anywhere on this branch — leftover from reconstructing the wake-plumbing commit (#521) off the monolithic feat/gos-unified-monitoring branch, which carried the file forward with these not-yet-landed PR #517 fields still attached. main has been non-compiling since #521 merged. The real GOS config plumbing lands properly, backed by its own fields, in the CountSketch GOS PR next in the stack. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainhas not compiled since #521 merged:processor.go(lines 177-179)referenced
fam.GosDeltaEpsilon/GosSites/GosAnisotropicandsketchOpts.gosDeltaEpsilon/gosSites/gosAnisotropic— none of which aredefined anywhere on
main. These are leftover from cherry-picking thewake-plumbing commit off the monolithic
feat/gos-unified-monitoringbranch: that branch's
processor.goalready carried later (not-yet-landed)PR #517-era GOS config-parsing lines, and the cherry-pick brought the whole
file hunk forward without noticing the corresponding
config.gofieldsweren't part of #521's actual diff.
Fix: delete the 3 stray struct-literal fields.
go build/go vet/go testnow pass clean on
asapedgeprocessor. The real GOS config plumbing(
GosDeltaEpsilon/GosSites— isotropic only, anisotropic was dropped fromthe design) lands properly, backed by real fields end to end, in the
CountSketch GOS conversion PR next in the stack.
Test plan
go build ./...clean onopentelemetry-collector-contrib/processor/asapedgeprocessor.go vet ./...clean.go test ./...clean (existing suite, no new tests needed for a pure deletion).🤖 Generated with Claude Code