chore: remove unused integration/ test suite - #450
Merged
Merged
Conversation
The integration/ suite (e2e cold/warm/kafka + three parity gates) had rotted into the worst state — half-maintained, protecting nothing: - No CI ran it (the repo has no .github / GitHub Actions). - parity/runtime-impl no longer compiled against current APIs (ddsketchprocessor.Config dropped MetricSuffix; the patched pmetric sketch datapoints dropped Count) — build failed. - The Go<->Rust cross-language gate was silently skipping: after #367 the goldens moved to integration/parity/runtime-impl/golden/, but the Rust test still looks under integration/parity/golden/, so load_golden returned None and every case returned early. Remove the suite plus its only functional dependency: - asap-precompute-rs/tests/cross_language_parity.rs — existed solely to load integration/parity/.../golden/*.bin (already a no-op skip). - .gitignore — drop the now-dead integration/parity/golden/*.bin rule. integration/ subdirs are standalone modules (no go.work, no Go importer), so removal is build-safe. Stale doc/comment references (docs/*.md, asap-precompute-go/sketches, countsketchprocessor, opentelemetry-go-patch) are non-breaking and left for a follow-up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the entire
integration/test suite (e2e cold/warm/kafka + the three parity gates) and its only functional dependency.Why — it had rotted into the worst state (half-maintained, protecting nothing)
.github/ Actions, so nothing exercised these tests automatically.parity/runtime-implno longer compiled against current APIs:ddsketchprocessor.ConfigdroppedMetricSuffixand the patchedpmetricsketch datapoints droppedCount, but the parity harness still referenced them →build failed.integration/parity/runtime-impl/golden/, butasap-precompute-rs/tests/cross_language_parity.rsstill looks underintegration/parity/golden/, soload_goldenreturnedNoneand every case returned early.What's removed
integration/(whole dir — 55 files:e2e-cold-path,e2e-kafka-cold-path,e2e-warm-path,parity/{runtime-impl,codec,agent-binary}).asap-precompute-rs/tests/cross_language_parity.rs— existed solely to loadintegration/parity/.../golden/*.bin..gitignore— the now-deadintegration/parity/golden/*.binrule.Safety
integration/subdirs are standalone Go modules: there is nogo.workand no Go file imports them, so removal doesn't affect any build. The deleted Rust test was an auto-discovered, self-contained integration target (no[[test]]entry, no shared module).Non-breaking stale references remain in design docs (
docs/*.md) and a few code comments (asap-precompute-go/sketches,countsketchprocessor,opentelemetry-go-patch); left out of this PR to keep it focused — easy follow-up if wanted.🤖 Generated with Claude Code