build(mvp-multinode): hand asap-gorilla-go to the gorilla-merger build - #436
Merged
Merged
Conversation
…rger build The gorilla-merger now imports the asap-gorilla-go intchunk subpackage (the cold value-chunk codec behind the decode-on-read helper), which is not in any published asap-gorilla-go tag. Pass the in-repo monorepo checkout to the build as the `asap-gorilla-go` build-context (mirroring data-plane's sibling path-deps and build_asap_otel.sh's replace); the merger Dockerfile rewrites its go.mod replace to point at it. Also add asap-gorilla-go to the required-build-inputs check. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to ASAPQuery-backend #333 (gorilla-merger decode-on-read for cold intchunk value chunks). The merger now imports
asap-gorilla-go/intchunk, which isn't in any published asap-gorilla-go tag, so its Dockerfile rewrites theasap-gorilla-gogo.mod replace to point at a build-context. This change supplies that build-context from the in-repo monorepo checkout (${ROOT}/asap-gorilla-go) inbuild_images(), mirroring how data-plane's sibling path-deps andbuild_asap_otel.shalready inject local asap-gorilla-go. Also addsasap-gorilla-goto the required-build-inputs preflight.Without this, the next
gorilla-mergerimage build fails (the Dockerfile expects theasap-gorilla-gobuild-context).Test plan
run_demo.sh buildrebuildsasap/gorilla-merger:devwith the asap-gorilla-go build-context (compiles against intchunk)