docs(multinode): clarify OpAMP URL is controller:4320, not backend:4320 - #384
Merged
Merged
Conversation
…:4320` The run_demo.sh comment around line 192 was a holdover from before PR #380 swept the agent OpAMP URLs from `ws://backend:4320` to `ws://controller:4320` (and ASAPQuery-backend PR #270 fixed the controller-side `CONTROLLER_OPAMP_ENDPOINT` default to match). Functionally `backend:4320` still works in the multinode topology because `--add-host=backend:${NODE2_IP}` resolves to the same IP as `--add-host=controller:${NODE2_IP}` — but the singlenode compose only has the `controller` alias, so that's the canonical URL the comment should document. Doc-only; no behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stale comment in
deploy/mvp-multinode/scripts/run_demo.sh:192still says agents point atws://backend:4320/v1/opamp, but #380 swept the agent-side URL tows://controller:4320and #270 (ASAPQuery-backend) fixed the controller default to match. Functionally both work in multinode (--add-hostfor both names resolves to NODE2_IP), but singlenode only has thecontrolleralias, so the canonical URL is the one this PR documents.Doc-only.
🤖 Generated with Claude Code