deploy(configs): canonical w/d param keys + retire SetAggregator notes - #379
Merged
Merged
Conversation
Two-part sync with asapquery-backend. 1. **Migrate CMS / CountSketch streaming-configs to canonical `w` / `d`** — sibling of asapquery-backend PR #268. The backend's `cms_params` helpers now read `w` (=cols) / `d` (=rows) first with `row_num` / `col_num` as legacy fallback, matching what the controller's `sketch_params_to_json` emits and what the OTLP policy_fp content match (`derive_sketch_policy_fp`) uses. The static asapcollector YAMLs were stuck on the older `row_num` / `col_num` form, which broke OTLP policy_fp lookup for sids ingested against these configs. Migrating to `w` / `d` aligns the static configs with the runtime expectation. 2. **Retire `SetAggregator` references** in inference-config doc comments. The exact-set-membership family (`SetAggregator` / `DeltaSetAggregator`) was retired wholesale in asapquery-backend PR #264. Comments here pointed at the retired family as a "tracked upstream" limitation for per-key top-K enumeration; updated to point at the actual solution (heap-bearing `CountSketchWithHeap` / `CountMinSketchWithHeap` from PR #258). No behavior change for the runtime — the backend's compat path (PR #268) keeps the legacy keys working, and the SetAggregator retirement (PR #264) doesn't affect any of the policies in these files. This is the static-config side of the cross-repo sync. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zzylol
added a commit
that referenced
this pull request
Jun 17, 2026
With the data-plane coordinator hot-reload landed (ASAPQuery-backend#379), Fig 9 no longer needs the seed-boot-config + restart-data-plane workaround: - mvp-workload-fig9.yaml: the monitor block now carries the real coordination params (tau 7000, window_secs 15) instead of placeholder tau 5e6 / 30 s, so the controller-published monitor is directly usable by the coordinator. - fig9_coordinated.sh: replace the seed+restart of asap-data-plane with a wait for the coordinator's 'hot-reloaded monitors' log — the monitor is picked up live. - RESULTS.md: bug #2 is now a code fix (#379), not a run-side workaround. Live-validated end-to-end (no seed, no restart): data-plane logs 'hot-reloaded monitors added=1', 0 unconfigured registrations, grants 0.0010/0.0022/0.0049 (hot/med/quiet) — identical to the boot-seed result and matching the sqrt(rate) law. REQUIRES ASAPQuery-backend#379 in the data-plane image. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cross-repo sync with asapquery-backend.
Two-part migration
Migrate CMS / CountSketch streaming-configs to canonical `w` / `d` — sibling of asapquery-backend PR eval(deploy): Dockerfile.backend build-context + accuracy_reduce regex post-#266 #268 (and follow-up fix(otlp): complete post-#262 DDSketch encoding-value + proto wire-type absorption #269). The backend's `cms_params` helpers read canonical `w` (=cols) / `d` (=rows) — what the controller's `sketch_params_to_json` emits and what the OTLP policy_fp content match uses. Static asapcollector YAMLs were stuck on the older `row_num` / `col_num` form, which broke OTLP policy_fp lookup for sids ingested against these configs.
Retire `SetAggregator` references in inference-config doc comments. The exact-set-membership family (`SetAggregator` / `DeltaSetAggregator`) was retired wholesale in asapquery-backend PR chore(docs): rename sketchlib-bench → sketch-bench references #264. Comments here pointed at the retired family as a 'tracked upstream' limitation for per-key top-K enumeration; updated to point at the actual solution (heap-bearing `CountSketchWithHeap` / `CountMinSketchWithHeap` from PR eval: fill nan columns in sweep CSV (paper blocker #3) #258).
Cross-repo ordering
This PR should merge first. Then asapquery-backend PR #269 (which drops the legacy `row_num` / `col_num` fallback) can merge safely.
🤖 Generated with Claude Code