fix(mvp): probe predicates use labels the fake-exporter actually emits - #369
Merged
Merged
Conversation
Three places in the MVP demo hardcoded predicates against `service`,
`status` labels that the fake-exporter never produces; those queries
returned empty (but HTTP 200) and masked any real cold-path / postings
behaviour they were meant to exercise.
The fake-exporter (`deploy/fake-exporter/main.go::attrSetsZRNP`)
emits `zone, rack, node, pod` labels. There is no `service` and no
`status` label in any series. Previous predicates:
- `service="payments"` / `service="api"` → matched 0 series
- `status=~"5.."` → matched 0 series
The cold-path probe verdict was technically PASS (HTTP 200 + the
`data_source: gorilla_archive` marker is present) but the actual
result was always `[]` — the demo was confirming "the archive
engine accepts queries", not "the archive engine returns data."
Repointed predicates to labels that exist:
- `deploy/configs/mvp-workload.yaml` entry 4 (criterion ⑤
cold-fallback probe): `service="payments"` → `zone="z0"`
- `deploy/scripts/run_mvp_demo.sh` Phase 5 cold-fallback curl +
log line: same change
- `deploy/scripts/run_mvp_demo.sh` Phase 4 postings probes:
`count(http_requests_total{service="api"})` →
`count(http_requests_total{zone="z0"})`;
`rate(http_requests_total{status=~"5.."}[5m])` →
`rate(http_requests_total{rack=~"r0[0-3]"}[5m])`
- `deploy/configs/backend-storage-routing.yaml` doc comment
Verified end-to-end (separate diagnostic run): with `zone="z0"`,
thanos-query returns non-empty `count` results — the cold path
actually serves data instead of returning HTTP-200-but-empty.
Output file basenames (`cold_payments.*`) kept for backwards
compatibility with `mvp_report.py`'s loader.
Verification:
- `pytest deploy/scripts/tests/test_mvp_report.py deploy/configs/tests/`
→ 35 passed.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three places in the MVP demo hardcoded predicates against `service`, `status` labels that the fake-exporter never produces; those queries returned empty (but HTTP 200) and masked any real cold-path / postings behaviour they were meant to exercise.
The fake-exporter (`deploy/fake-exporter/main.go::attrSetsZRNP`) emits `zone, rack, node, pod` labels. No `service` and no `status` label exists in any series. Previous predicates:
The cold-path probe verdict was technically PASS (HTTP 200 + `data_source: gorilla_archive` marker present) but the actual `result: []` was always empty. Demo was confirming "archive engine accepts queries", not "archive engine returns data."
Changes
"5.."` → `rack="r0[0-3]"`Output file basenames (`cold_payments.*`) kept for backwards compatibility with `mvp_report.py`'s loader.
Test plan
Companion
Pairs with #368 (the `mvp-no-resource-limits.yml` override) — without the resource cap fix, agents OOM-restart and produce 1-ms-wide TSDB blocks that the lookback miss compounds; with the cap lifted + correct predicates, the cold-path round-trip should actually return data.
🤖 Generated with Claude Code