cleanup: delete cmd/bench.sh, repoint Serf bench docs - #364
Merged
Merged
Conversation
After cleanup PR #363 deleted the per-sketch / per-collector cmd dirs (`countminsketchcol`, `ddsketchcol`, `hllcol`, `serfcol`, `gorillacol`, etc.), only the `kll*` branches in `cmd/bench.sh` had functioning build targets — 23 of 28 case branches pointed at deleted directories. Rather than trim to a kll-only stub of a 922-line script, drop the harness entirely and route bandwidth/CPU/throughput measurements through the MVP demo's `measure_stages.py` + `measure_per_edge_bandwidth.py` (which work against the unified `asap-otel` build). The Serf compression architecture doc had a "Benchmark targets" section listing 11 deleted bench.sh invocations; replaced with a brief note explaining the harness was removed and pointing at the live processor (`serfprocessor` is still in the patched contrib tree) plus the MVP measurement scripts. The opentelemetry-app README's "Running via bench.sh" subsection was a single dangling pointer; removed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After cleanup PR #363 deleted the per-sketch / per-collector cmd dirs (
countminsketchcol,ddsketchcol,hllcol,serfcol,gorillacol, etc.), onlykll*branches incmd/bench.shhad functioning build targets — 23 of 28 case branches pointed at deleted directories. Drop the 922-line harness entirely; route bandwidth/CPU/throughput measurements through the MVP demo'smeasure_stages.py+measure_per_edge_bandwidth.py(which work against the unifiedasap-otelbuild).3 files, +12 / −961.
opentelemetry-collector-contrib-patch/cmd/bench.shdocs/serf-compression-architecture.md: replaced "Benchmark targets" section (11 deadbench.shinvocations) with a brief note pointing at the liveserfprocessor+ MVP measurement scriptsopentelemetry-app/README.md: removed dangling "Running via bench.sh" subsectionTest plan
bench.sh; all callers were docs/READMEs (verified via grep)serfprocessoritself remains in patched contrib tree and registered incmd/asap-otel/builder-config.yaml🤖 Generated with Claude Code