mvp_reducer: add frequency branch (rate(metric[5m])) — CountMin per-series ε - #343
Merged
Merged
Conversation
…eries ε PR #338 added frequency to the replay client's QUERY_KINDS but the reducer silently skipped frequency rows because parse_query had no `rate()` regex. This adds: - `_RATE_RE` matching `rate(metric[5m])` shape - parse_query returns ("frequency", {"metric": ...}) - new `extract_per_series` helper: PromQL vector → {labels-key → value} - frequency branch in reduce_cell_via_archive: pair warm vs archive per-series, compute mean absolute additive error normalised by truth total — comparable column with rel_err for other kinds - frequency branch in archive_miss fallback path so warm_answer is still captured for diagnostics Refs #46. Closes the gap PR #338 flagged. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zzylol
force-pushed
the
mvp/reducer-frequency-branch
branch
from
May 8, 2026 18:58
37bafa9 to
ec7a6da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #338 added frequency to the replay client but the reducer silently skipped those rows. This closes the gap.
_RATE_REforrate(metric[5m])shapeextract_per_serieshelper for vector resultsRefs #46. 🤖 Claude Code