mvp: enable USE_TYPED_STAGE_SPLIT=1 in demo controller env (activates typed bootstrap + replan + 5-sketch routing) - #341
Merged
Conversation
Activates the typed-stage-split path for every compose invocation that includes base.yml, so the demo (and any ad-hoc `docker compose up controller` against base alone) routes through the typed pipeline: bootstrap GET (#329), OpAMP-on-connect replan (#334), and per-metric 5-sketch family routing (#339 + #340 + the in-flight stitching PR). The mvp-multi-stage.yml overlay already sets the same default; this just promotes the gate to the base layer so it is on without the overlay. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes the
USE_TYPED_STAGE_SPLIT=1gate from themvp-multi-stage.ymloverlay todeploy/docker-compose/base.ymlso the demo (and any ad-hocdocker compose -f base.yml up controller) routes the controller through the typed-stage-split path by default. Tracks #46.What flips on with this env (verified via 30-second smoke test):
/api/v1/collector-config/agent— typed pipeline via controller: port handle_bootstrap_agent_config to typed-stage-split path #329.handle_planreplan ported to typed).run_mvp_demo.shalready exports the var with default1; the only file changed isdeploy/docker-compose/base.yml. Override is still respected (e.g.USE_TYPED_STAGE_SPLIT=0 docker compose up controllerfor the legacy free-form emitter, useful for A/B comparison).Smoke-test evidence
The
[USE_TYPED_STAGE_SPLIT]markers frompushing typed edge YAML,posting typed backend JSON, andstorage-routing JSON push succeededconfirm all three arms (edge OpAMP push, backend StreamingConfig POST, per-metric storage-routing POST) are firing through the typed pipeline.Test plan
compose up -d controller backend minio, POST canonical workload to/api/v1/plan, grepUSE_TYPEDin controller logs — markers present.${USE_TYPED_STAGE_SPLIT:-1}interpolation — operators can flip back to0for the legacy emitter without editing the file.run_mvp_demo.shinvocation will exercise this).🤖 Generated with Claude Code