Conversation
…ndow mode - Add `temporality` field to `metricWindow` to preserve DDSketch AggregationTemporality - Store temporality in `accumulateDDSketchMetric` - Use stored temporality when rebuilding metric in `flushWindow` - Assert output temporality matches input (Delta) in the window-mode test Co-authored-by: zzylol <50204836+zzylol@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update to address feedback on DDSketch modes and benchmarks
Fix DDSketch AggregationTemporality loss in window-mode flush
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Window-mode flush was silently dropping
AggregationTemporalityfrom DDSketch outputs.flushWindowbuilt a barepmetric.Metric(no type set), causingbuildMergedSketchMetricto always emitAggregationTemporalityUnspecifiedinstead of preserving the input temporality.Changes
metricWindowstruct — addedtemporality pmetric.AggregationTemporalityfield to carry the value through window accumulationaccumulateDDSketchMetric— storesmetric.DDSketch().AggregationTemporality()ontomw.temporalityon each accumulationflushWindow— seeds thetmpmetric viatmp.SetEmptyDDSketch().SetAggregationTemporality(mw.temporality)before passing tobuildMergedSketchMetric, so the existing DDSketch type-check in that function correctly propagates the preserved temporalityprocessor_test.go— adds an explicit assertion in the window-mode merge test:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.