docs: update runbook + cold-engine design to 2-tier framing - #313
Merged
Merged
Conversation
Step-1 of the JSONL deprecation refactor (backend PR #95 + collector PR #312) deleted the legacy JSONL cold-fallback leg (LocalFsColdStore, parse_jsonl, the gateway-side raw-tee, the ColdJsonlFallback StorageBackend variant). This commit propagates the change into the runbook + cold-engine design doc: * docs/mvp-demo-runbook.md - rewrite the §"Out of scope for the demo" / §"Open gaps" references to point at the surviving Gorilla archive engine instead of the deleted JSONL ground-truth path - drop the LocalFsColdStore row from §Component status; rename the GorillaS3ColdStore row to GorillaS3Store (Step-1 rename); point at s3_cost.rs instead of the renamed s3_cost_tracker - move the "Delete LocalFsColdStore + JSONL gateway raw-tee + cost_model cold-tier scan-bytes" item from §Planned to DONE - flag Step-2 (Prometheus-TSDB block format + Thanos store-gateway) as the path to full PromQL parity on the archive tier * docs/design-gorilla-s3-cold-engine.md - update §3 e2e architecture: 2-tier framing, drop the "raw-tee exporter (cold JSONL)" leg from the block diagram, drop the "cold-JSONL fallback (forwarding adapters / LocalFsColdStore) — UNCHANGED" branch, capability miss now surfaces as 404 not a JSONL scan - swap GorillaS3ColdStore → GorillaS3Store in the diagram - add the routing/ module reference (the dispatcher moved out of engines/router.rs in Step-1) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step-1 of the JSONL deprecation refactor (backend PR ProjectASAP/ASAPQuery-backend#95 + collector PR #312) deleted the legacy JSONL cold-fallback leg (LocalFsColdStore, parse_jsonl, the gateway-side raw-tee, the ColdJsonlFallback StorageBackend variant). This follow-up propagates the change into the runbook + cold-engine design doc.
Changes
docs/mvp-demo-runbook.md:LocalFsColdStorerow from §Component status; rename theGorillaS3ColdStorerow toGorillaS3Store(Step-1 rename); point ats3_cost.rsinstead of the renameds3_cost_trackerLocalFsColdStore+ JSONL gateway raw-tee +cost_modelcold-tier scan-bytes" item from §Planned to DONEdocs/design-gorilla-s3-cold-engine.md:GorillaS3ColdStore→GorillaS3Storein the diagramrouting/module reference (the dispatcher moved out ofengines/router.rsin Step-1)Test plan
🤖 Generated with Claude Code