fix(controller): add data_sink field to test-fixture AgentCollectorConfig constructors

[zzylol]

Summary

PR #204 added the data_sink: AgentDataSink field to AgentCollectorConfig (production sites updated) but missed nine test-fixture / test-code constructors, leaving cargo test --release -p controller blocked at compile-time. This was the baseline blocker that downstream PRs (#273, #274, #275) flagged — none of them could run their newly added unit tests until this lands.

Mechanical fill-in only:

• 7 sites use AgentDataSink::default() (Otlp-to-backend) — the canonical default that PR feat(e2e): all-five-sketch runtime path + harness — controller, processor, fake-exporter, P1–P9 #204 introduced for new pipelines.
• 2 sites pin AgentDataSink::PrometheusScrape { endpoint: "0.0.0.0:8889" } to keep the existing test semantics:
  • config::agent::tests::ddsketch_cfg — used by contains_prometheus_exporter + pipeline_has_receivers_and_exporters, both of which assert the legacy prometheus exporter on :8889.
  • main::api_tests::generated_agent_yaml_contains_opamp_extension — asserts doc["exporters"]["prometheus"].is_mapping() at line ~1326.

Touch boundary respected: only controller/src/config/agent.rs, controller/src/config/asapquery_backend.rs, controller/src/config/precompute.rs, and controller/src/main.rs (test-code area). controller/src/types.rs left as-designed.

Sites updated (file:line)

• controller/src/config/agent.rs:222 — ddsketch_cfg() (PrometheusScrape)
• controller/src/config/agent.rs:301 — hll_processor
• controller/src/config/agent.rs:331 — countminsketch_processor
• controller/src/config/agent.rs:436 — kll_processor
• controller/src/config/agent.rs:463 — countsketch_processor
• controller/src/config/agent.rs:508 — all_sketch_types_processor_key_matches_pipeline_ref
• controller/src/config/asapquery_backend.rs:190 — dummy_plan (also added AgentDataSink to the test-mod import list)
• controller/src/config/precompute.rs:196 — dummy_plan
• controller/src/main.rs:1282 — generated_agent_yaml_contains_opamp_extension (PrometheusScrape)

Test plan

• cargo build --release -p controller clean (was already clean).
• cargo test --release -p controller --no-run clean (was the blocker — 9 E0063 errors).
• cargo test --release -p controller runs 395 tests: 389 pass, 6 pre-existing failures unrelated to data_sink:
  • 2 in analyzer::tests — float-precision asserts (0.010000000000000009 != 0.01).
  • 4 in opamp::tests / api_tests — protobuf framing ("invalid tag value: 0") on ServerToAgent decode.
  • These are tracked separately and out of scope for this PR.
• Newly-shipped tests now run end-to-end:
  • query_language (8 tests, all pass)
  • language_logical_plan (6 tests, all pass)
  • types_v2 (7 tests, all pass)
  • algebra (intent-algebra family — agg_intent_*, resolve_preserves_intent, all pass)
• cargo clippy --release -p controller --all-targets -- -D warnings — no NEW lints from the modified sites (the diff between baseline and post-fix surfaces only pre-existing dead-code warnings that the test target now exposes once it compiles).

🤖 Generated with Claude Code