docs(design): asap-telegraf integration — unified allsketches plugin - #233
Merged
Merged
Conversation
Mirror the OTel two-layer split: asap-precompute-go/telegraf codec (data-shape translation) and telegraf-patch/processors/allsketches plugin (lifecycle glue). One unified plugin with sketch_type as config instead of 5 separate plugins, since Telegraf is greenfield (no parity-preservation constraint like the OTel collector). Reuses asap-precompute-go runtime + sketches wrappers + controlchannel unchanged. Estimated ~1500 LoC of new Telegraf-specific code. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design doc for Telegraf integration into the ASAP edge precompute framework. Mirrors the OTel two-layer split (codec under
asap-precompute-go/telegraf/, lifecycle plugin undertelegraf-patch/processors/allsketches/) and reuses the runtime / sketches wrappers / control-channel unchanged.Key design choice: ship a single unified
allsketchesplugin withsketch_typeas a config field, NOT five separate plugins as the OTel side has — Telegraf is greenfield, so there is no behavior-preservation constraint forcing the type-per-plugin split.Total new code estimated at ~1500 LoC (codec ~500, plugin ~800, registration patch ~10, build script ~80).
Doc-only PR — no code. Review for design alignment before implementation begins (Phase B onwards).
Test plan
design-asap-edge-framework.md§6, §7 and ADR-0002 / ADR-0003.value_field(single field) v1 scope and the deferred multi-field v2 path are acceptable.go buildfrom patched fork, no OCB equivalent needed).