Skip to content

build(sketchcollector): wire asap-precompute-go replace directive #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzylol merged 1 commit into from
May 4, 2026
Merged

build(sketchcollector): wire asap-precompute-go replace directive #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build_sketchcollector.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,9 @@ SKETCHCOL_DIR="${PATCH_DIR}/cmd/sketchcollector"
if ! grep -qE "^replace[[:space:]]+github\.com/ProjectASAP/sketchlib-go" "${SKETCHCOL_DIR}/go.mod" 2>/dev/null; then
echo "replace github.com/ProjectASAP/sketchlib-go => ${ROOT_DIR}/../sketchlib-go" >> "${SKETCHCOL_DIR}/go.mod"
fi
if ! grep -qE "^replace[[:space:]]+github\.com/ProjectASAP/asap-precompute-go" "${SKETCHCOL_DIR}/go.mod" 2>/dev/null; then
echo "replace github.com/ProjectASAP/asap-precompute-go => ${ROOT_DIR}/asap-precompute-go" >> "${SKETCHCOL_DIR}/go.mod"
fi

cd "${SKETCHCOL_DIR}"
GONOSUMCHECK="github.com/ProjectASAP/*" GONOSUMDB="github.com/ProjectASAP/*" go build -o sketchcollector . 2>&1
Expand Down
9 changes: 9 additions & 0 deletions opentelemetry-collector-contrib-patch/cmd/sketchcollector/builder-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,3 +322,12 @@ replaces:
# published commit and ApplyDelta / SerializeMsgpack /
# NewFromState constructors would not resolve.
- github.com/ProjectASAP/sketchlib-go => ../../../../sketchlib-go
# asap-precompute-go is a private module living as a sibling
# subdirectory of this repo (ASAPCollector/asap-precompute-go).
# Same redirect intent as sketchlib-go but a different path: the
# OCB-generated cmd/sketchcollector/go.mod lives 3 dirs deep under
# the ASAPCollector repo root (`./opentelemetry-collector-contrib-patch/cmd/sketchcollector`),
# so ../../../asap-precompute-go resolves to the in-repo subdirectory.
# (sketchlib-go uses one extra `..` because it lives as a sibling
# repo of ASAPCollector, one level up from this repo root.)
- github.com/ProjectASAP/asap-precompute-go => ../../../asap-precompute-go