Skip to content

proto: add *_ENCODING_MSGPACK variants to sketch encoding enums #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzylol merged 1 commit into from
Apr 14, 2026
Merged

proto: add *_ENCODING_MSGPACK variants to sketch encoding enums #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions opentelemetry-proto-patch/opentelemetry/proto/metrics/v1/metrics.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,12 @@ enum DDSketchEncoding {
// github.com/DataDog/sketches-go/ddsketch/pb/sketchpb.DDSketch message.
DDSKETCH_ENCODING_PROTO = 1;
DDSKETCH_ENCODING_PROTO_DELTA = 2;
// DDSKETCH_ENCODING_MSGPACK indicates the sketch bytes are the MessagePack
// serialization of the cross-language sketch-core `DdSketch` struct
// (matching ASAPQuery-backend's `sketch_core::dd_sketch::DdSketch` and
// sketchlib-go's `wire/asapmsgpack.DDSketchState`).
DDSKETCH_ENCODING_MSGPACK = 3;
DDSKETCH_ENCODING_MSGPACK_DELTA = 4;
}

// KLLSketch represents the type of a metric that encodes measurements using the KLL quantile sketch.
Expand Down Expand Up @@ -415,6 +421,13 @@ message KLLSketchDataPoint {
enum KLLSketchEncoding {
KLL_SKETCH_ENCODING_UNSPECIFIED = 0;
KLL_SKETCH_ENCODING_PROTO = 1;
// KLL_SKETCH_ENCODING_MSGPACK is reserved for the cross-language
// sketch-core `KllSketch` msgpack wire format. Not currently usable
// because sketchlib-go's KLL does not share a byte-level backend
// with ASAPQuery-backend's datasketches-rs-backed `KllSketch`
// (tracked as a follow-up — for KLL today, use PROTO).
KLL_SKETCH_ENCODING_MSGPACK = 3;
KLL_SKETCH_ENCODING_MSGPACK_DELTA = 4;
}

// CountSketch represents the type of a metric that encodes frequency estimations using CountSketch.
Expand Down Expand Up @@ -446,6 +459,13 @@ enum CountSketchEncoding {
COUNT_SKETCH_ENCODING_UNSPECIFIED = 0;
COUNT_SKETCH_ENCODING_PROTO = 1;
COUNT_SKETCH_ENCODING_DELTA = 2;
// COUNT_SKETCH_ENCODING_MSGPACK indicates the sketch bytes are the
// MessagePack serialization of the cross-language sketch-core
// `CountSketch` struct (matching ASAPQuery-backend's
// `sketch_core::count_sketch::CountSketch` and sketchlib-go's
// `wire/asapmsgpack.MarshalCountSketch`).
COUNT_SKETCH_ENCODING_MSGPACK = 3;
COUNT_SKETCH_ENCODING_MSGPACK_DELTA = 4;
}

// CountMinSketch represents the type of a metric encoding frequency estimations using CountMinSketch.
Expand Down Expand Up @@ -477,6 +497,13 @@ enum CountMinSketchEncoding {
COUNT_MIN_SKETCH_ENCODING_UNSPECIFIED = 0;
COUNT_MIN_SKETCH_ENCODING_PROTO = 1;
COUNT_MIN_SKETCH_ENCODING_DELTA = 2;
// COUNT_MIN_SKETCH_ENCODING_MSGPACK indicates the sketch bytes are
// the MessagePack serialization of the cross-language sketch-core
// `CountMinSketch` wire struct (matching ASAPQuery-backend's
// `sketch_core::count_min::CountMinSketch` and sketchlib-go's
// `wire/asapmsgpack.MarshalCountMinSketch`).
COUNT_MIN_SKETCH_ENCODING_MSGPACK = 3;
COUNT_MIN_SKETCH_ENCODING_MSGPACK_DELTA = 4;
}

// HLLSketch represents the type of a metric that encodes cardinality estimations using HyperLogLog.
Expand Down Expand Up @@ -508,6 +535,13 @@ enum HLLSketchEncoding {
HLL_SKETCH_ENCODING_UNSPECIFIED = 0;
HLL_SKETCH_ENCODING_PROTO = 1;
HLL_SKETCH_ENCODING_DELTA = 2;
// HLL_SKETCH_ENCODING_MSGPACK indicates the sketch bytes are the
// MessagePack serialization of the cross-language sketch-core
// `HllSketch` struct — registers + variant + precision + HIP state
// (matching ASAPQuery-backend's `sketch_core::hll_sketch::HllSketch`
// and sketchlib-go's `wire/asapmsgpack.MarshalHLLSketch`).
HLL_SKETCH_ENCODING_MSGPACK = 3;
HLL_SKETCH_ENCODING_MSGPACK_DELTA = 4;
}

// AggregationTemporality defines how a metric aggregator reports aggregated
Expand Down