Repository navigation
New features - #18
New features#18alliemr123 wants to merge 17 commits into
Conversation
Add MHKiT Wave YAML Writer documentation detailing features, command structure, and usage examples.
Added documentation for the `--direction_file` option, including usage examples and details about the directional spectrum format.
alliemr123
left a comment
There was a problem hiding this comment.
added --direction_file for custom input wave directions
alliemr123
left a comment
There was a problem hiding this comment.
Added --save feature to save .pngs of figures
alliemr123
left a comment
There was a problem hiding this comment.
fix formatting with yaml.dump on body damping
alliemr123
left a comment
There was a problem hiding this comment.
updated directional writing/formatting for WITT model
|
Thanks Allie - this looks really useful. I've had a local run through the writer/reader and the overall approach looks good. Keeping each tool as one script plus a README is the right shape. There are a few things I think we should fix or clarify before merging:
A couple of things on the writer behaviour:
One smaller thing: rewriting the hydro YAML through PyYAML strips existing comments (the usual write, and the same pattern at line 662 and line 2374). It would be nice to preserve those if practical. Wrapping the work in a Nothing here looks fundamental, and I didn't hit any conflicts with current |
Adding four files: H5 output reader, corresponding readme description, MHKiT wave yaml writer, and corresponding description.