Repository navigation
Add unet++ notebook - #1476
Add unet++ notebook#1476
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
e721728 to
1e57ab0
Compare
5ae1724 to
688d3df
Compare
|
thanks, please follow this https://github.com/Project-MONAI/tutorials/blob/main/CONTRIBUTING.md#create-a-notebook to create the necessary cells, I think you can copy them from https://github.com/Project-MONAI/tutorials/blob/main/modules/UNet_input_size_constrains.ipynb |
Signed-off-by: nhhung1810 <nghung224@gmail.com>
Signed-off-by: nhhung1810 <nghung224@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: nhhung1810 <nghung224@gmail.com>
Signed-off-by: nhhung1810 <nghung224@gmail.com>
5ec357b to
ac68e50
Compare
|
After several trial, I finally understand the basic process, hope you guy can check on the notebook content :D |
|
Thank you @nhhung1810 for the PR. I just started to read the notebook. I noticed that there are many commented code, and the last cell has outputs from all-commented code block. May I know what the commented code is for? |
|
Hey @mingxin-zheng , that commented code is for exploration on the implementation of UNET++. I'll delete it after the other things resolved |
|
thanks! would be great to have a conclusion section to recommend the usage, for example, about how to set number of downsampling layers and input spatial sizes, and the normalisation argument might require a tuple for additional parameters https://github.com/Project-MONAI/MONAI/blob/6f5cea3795278c20568261ebb38907d94b576b98/monai/networks/nets/daf3d.py#L490-L491. the current notebook explores many tests but it's unclear to me what are the suitable configurations for this model. |
|
Sure @wyli, I'll dig into the original papers and others papers to write the conclusion. Also, I'll include a network image for reference |
Signed-off-by: nhhung1810 <nghung224@gmail.com>
|
Just add some conclusions to the normalization (also an example of passing norm's argument) and up/down-sampling sections. I also comment about the |
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me.
Fixes Project-MONAI#1475. ### Description A few sentences describing the changes proposed in this pull request. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: nhhung1810 <nghung224@gmail.com>
Fixes #1475.
Description
A few sentences describing the changes proposed in this pull request.
Checks
./figurefolder./runner.sh -t <path to .ipynb file>