Skip to content

feat: found a lost document - #389

Merged
kaitoz11 merged 1 commit into
devfrom
feat/report-found-document
Jul 30, 2023
Merged

kaitoz11 merged 1 commit into
devfrom
feat/report-found-document

Conversation

@kaitoz11

Copy link
Copy Markdown
Member

No description provided.

@kaitoz11 kaitoz11 added enhancement New feature or request help wanted Extra attention is needed labels Jul 28, 2023
@kaitoz11
kaitoz11 requested a review from ChienNQuang July 28, 2023 10:09
@kaitoz11 kaitoz11 self-assigned this Jul 28, 2023

@ChienNQuang ChienNQuang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wut

{
if (borrow.DueTime < localDateTimeNow)
{
borrow.Status = BorrowRequestStatus.Pending;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we found a lost document which some of it's borrow requests due time is your grandma's birthday?

@kaitoz11 kaitoz11 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! F you

{
if (borrow.DueTime < localDateTimeNow)
{
borrow.Status = BorrowRequestStatus.Pending;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

@vzart
vzart requested a review from ChienNQuang July 30, 2023 09:53
@kaitoz11
kaitoz11 merged commit c9f4e7e into dev Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants