Skip to content

[@proicons/react] color attr bleeds to other images of same type #5

Description

@alexz-prod

When specifying color="mycolor" on an icon and then reusing the same icon somewhere in the app without a color attribute, the icon always uses mycolor instead of currentColor. This doesn't affect other icons.

Example:

<div style={{ color: 'green' }}>
  <AddIcon color="red" /> {/* red ✓ */}
  <TvIcon /> {/* green ✓ */}
</div>
<div style={{ color: 'blue' }}>
  <AddIcon /> {/* red x */}
  <TvIcon /> {/* blue ✓ */}
</div>

stackblitz: https://stackblitz.com/edit/vitejs-vite-rnnxlf9v?file=src%2Fmain.tsx&terminal=dev

Thanks for the great icons!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

🐛 bugSomething isn't working

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions