Allow for suppression of custom rules - #1145
Merged
Christoph Bergmeister (bergmeister) merged 6 commits intoMar 5, 2019
Merged
Conversation
…oid breaking existing functionality, therefore also revert the last change in test file
…uppressing custom rules when there is no Extent supplied
…o be able to cope with it
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
February 24, 2019 15:37
Christoph Bergmeister (bergmeister)
added
the
(Re-)Review Needed
Rob Holt (rjmholt)
approved these changes
Mar 5, 2019
Christoph Bergmeister (bergmeister)
added a commit
to bergmeister/PSScriptAnalyzer
that referenced
this pull request
Mar 22, 2019
* Fix rule name lookup mismatch for custom rules to allow for suppresion and unify code * Remove note that custom rules suppression are not supported * fix CustomizedRule.tests.ps1 * do not change GetName method and add GetFullName method instead to avoid breaking existing functionality, therefore also revert the last change in test file * Add test and fix dummy test rule to return script extent. TODO: Fix suppressing custom rules when there is no Extent supplied * Make test custom rule return null extent again by fixing the Engine to be able to cope with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
GetFullNamein the rule suppression lookup code as custom rules have a longer rule name. This might be also interesting for you guys: Laurent Dardenne (@LaurentDardenne) Thomas Rayner (@thomasrayner)Extentis not set (i.e. null), before PSSA threw NullReferenceExceptions.PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.