Add error when using dism resources via Appx - #1479
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a targeted, user-friendly error for a known limitation where DISM APIs aren’t accessible when the resource is installed via Appx, surfacing a clearer failure mode during session initialization.
Changes:
- Detect
REGDB_E_CLASSNOTREGfromDismInitializeandDismOpenSessionand return a dedicated localized error. - Add a new
dism.notSupportedAppxlocalized string for the new error path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| resources/dism_dsc/src/dism.rs | Adds HRESULT check for REGDB_E_CLASSNOTREG during DISM initialization/session open and returns a localized “not supported via Appx” error. |
| resources/dism_dsc/locales/en-us.toml | Adds the notSupportedAppx message used by the new error path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
There is a known issue with Appx that prevents access to dism APIs. So if the error returned indicates the class is not registered, tell the user it is not supported.